Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant inline #377

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove redundant inline #377

merged 1 commit into from
Oct 16, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Oct 9, 2024 •
edited by tmadlener
Loading

BEGINRELEASENOTES

  • Remove redundant inline from templated utility functions.

ENDRELEASENOTES

@tmadlener
Copy link
Contributor

In this case it's the templates that (implicitly) make these inline, not the constexpr, I think. (At least that is what I got from the discussion in AIDASoft/podio#694.

However, it doesn't really matter, the inline is still redundant ;)

@tmadlener tmadlener merged commit 22e85d7 into main Oct 16, 2024
14 of 15 checks passed
@tmadlener tmadlener deleted the remove-inline branch October 16, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener